Wow.
Now this is kinda shocking.
Well, no "don't!" from me. I'm a realist; I don't completely like armed forces but I realize they're needed - very needed! - in this world.
But it's still very strange for me... this is the first time I've met someone who willingly joins the army. I guess I can understand it, as the pros you listed didn't sound bad, and Canada is a pretty peaceful country so with some luck you won't be in many dangerous situations. (or at least that's the image Canada has, could be wrong?)
I wouldn't count the two-years training as a con, by the way. It sounds lenghty, yeah, but you'll learn a lot. By the time you're done with just the training, you'll probably be among the best in your area... at least in my country, it's common knowledge that military people are usually the best engineers, surgeons, trainers, planners and advisors.
So, my final thoughts? Go ahead. Sounds like a great opportunity, evenmore so because you chose it, instead of just being drafted.
Afterthoughts - post a pic of yourself in uniform as soon as you can! Me loves men in uniforms!